Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve unit-test for subnet service #850

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wenqiq
Copy link
Contributor

@wenqiq wenqiq commented Oct 31, 2024

Improve unit-test for Subnet service
Improve the log of the Subnet/SubnetSet controller

@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 31.81818% with 15 lines in your changes missing coverage. Please review.

Project coverage is 64.91%. Comparing base (4246c65) to head (8d135ec).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pkg/nsx/services/subnet/subnet.go 20.00% 12 Missing ⚠️
pkg/controllers/subnet/subnet_controller.go 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #850      +/-   ##
==========================================
+ Coverage   64.52%   64.91%   +0.38%     
==========================================
  Files          96       96              
  Lines       15153    15125      -28     
==========================================
+ Hits         9778     9818      +40     
+ Misses       4676     4607      -69     
- Partials      699      700       +1     
Flag Coverage Δ
unit-tests 64.91% <31.81%> (+0.38%) ⬆️
Files with missing lines Coverage Δ
pkg/controllers/subnetset/subnetset_controller.go 78.81% <100.00%> (-1.19%) ⬇️
pkg/controllers/subnet/subnet_controller.go 76.00% <25.00%> (-0.77%) ⬇️
pkg/nsx/services/subnet/subnet.go 37.95% <20.00%> (+12.26%) ⬆️

... and 1 file with indirect coverage changes

@wenqiq wenqiq force-pushed the topic/wenqi/improve-service-ut branch from 868eb3d to 8d135ec Compare November 1, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants