Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid potential nil pointers in compare.go #848

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zhengxiexie
Copy link
Contributor

No description provided.

@zhengxiexie zhengxiexie force-pushed the topic/zhengxie/main/avoid_pentential_nil branch 4 times, most recently from 0d89976 to d87ac10 Compare November 1, 2024 02:56
@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 26.66667% with 11 lines in your changes missing coverage. Please review.

Project coverage is 73.33%. Comparing base (86c0d65) to head (f67560a).

Files with missing lines Patch % Lines
pkg/nsx/services/common/compare.go 26.66% 8 Missing and 3 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #848      +/-   ##
==========================================
- Coverage   73.37%   73.33%   -0.05%     
==========================================
  Files         118      118              
  Lines       16394    16409      +15     
==========================================
+ Hits        12029    12033       +4     
- Misses       3581     3589       +8     
- Partials      784      787       +3     
Flag Coverage Δ
unit-tests 73.33% <26.66%> (-0.05%) ⬇️
Files with missing lines Coverage Δ
pkg/nsx/services/common/compare.go 77.08% <26.66%> (-22.92%) ⬇️

@zhengxiexie
Copy link
Contributor Author

/e2e

7 similar comments
@zhengxiexie
Copy link
Contributor Author

/e2e

@zhengxiexie
Copy link
Contributor Author

/e2e

@zhengxiexie
Copy link
Contributor Author

/e2e

@zhengxiexie
Copy link
Contributor Author

/e2e

@zhengxiexie
Copy link
Contributor Author

/e2e

@zhengxiexie
Copy link
Contributor Author

/e2e

@zhengxiexie
Copy link
Contributor Author

/e2e

@zhengxiexie zhengxiexie force-pushed the topic/zhengxie/main/avoid_pentential_nil branch from d87ac10 to f67560a Compare December 23, 2024 02:40
@zhengxiexie
Copy link
Contributor Author

/e2e

3 similar comments
@zhengxiexie
Copy link
Contributor Author

/e2e

@zhengxiexie
Copy link
Contributor Author

/e2e

@zhengxiexie
Copy link
Contributor Author

/e2e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants