-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid potential nil pointers in compare.go #848
Open
zhengxiexie
wants to merge
1
commit into
vmware-tanzu:main
Choose a base branch
from
zhengxiexie:topic/zhengxie/main/avoid_pentential_nil
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Avoid potential nil pointers in compare.go #848
zhengxiexie
wants to merge
1
commit into
vmware-tanzu:main
from
zhengxiexie:topic/zhengxie/main/avoid_pentential_nil
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengxiexie
force-pushed
the
topic/zhengxie/main/avoid_pentential_nil
branch
4 times, most recently
from
November 1, 2024 02:56
0d89976
to
d87ac10
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #848 +/- ##
==========================================
- Coverage 73.37% 73.33% -0.05%
==========================================
Files 118 118
Lines 16394 16409 +15
==========================================
+ Hits 12029 12033 +4
- Misses 3581 3589 +8
- Partials 784 787 +3
|
/e2e |
7 similar comments
/e2e |
/e2e |
/e2e |
/e2e |
/e2e |
/e2e |
/e2e |
Signed-off-by: Xie Zheng <[email protected]>
zhengxiexie
force-pushed
the
topic/zhengxie/main/avoid_pentential_nil
branch
from
December 23, 2024 02:40
d87ac10
to
f67560a
Compare
/e2e |
3 similar comments
/e2e |
/e2e |
/e2e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.