Remove vpcPath from networkinfo CRD #828
Open
+1
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #828 +/- ##
==========================================
- Coverage 70.63% 70.62% -0.01%
==========================================
Files 95 95
Lines 15077 15076 -1
==========================================
- Hits 10649 10648 -1
Misses 3704 3704
Partials 724 724
|
dantingl
previously approved these changes
Oct 30, 2024
lxiaopei
reviewed
Oct 30, 2024
seanpang-vmware
dismissed stale reviews from dantingl and wenyingd
via
ac90eba
seanpang-vmware
force-pushed
the
removeip
branch
from
694eb51
to
ac90eba
Compare
dantingl
previously approved these changes
Oct 30, 2024
lxiaopei
previously approved these changes
Oct 30, 2024
dantingl
reviewed
Oct 30, 2024
seanpang-vmware
dismissed stale reviews from lxiaopei and dantingl
via
e8ba902
seanpang-vmware
force-pushed
the
removeip
branch
from
ac90eba
to
e8ba902
Compare
|
/e2e |
seanpang-vmware
force-pushed
the
removeip
branch
3 times, most recently
from
772f3f5
to
afe9ff4
Compare
After wcp merged the changes for getting vpcPath from networkconfig CR, remove the previous protection code by setting redundant vpcPath value on networkinfo CR
seanpang-vmware
force-pushed
the
removeip
branch
from
afe9ff4
to
d65f4de
Compare
there is no new code change on api client after generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After wcp merged the changes for getting vpcPath from networkconfig CR, remove the previous protection code by setting redundant vpcPath value on networkinfo CR