Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change GatewayAPI type in adc to boolean pointer #174

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

chenlin07
Copy link
Contributor

What this PR does / why we need it:

Change GatewayAPI type in adc to boolean pointer

Which issue(s) this PR fixes:

Fixes #

Describe testing done for PR:

Special notes for your reviewer:

Release note:


New PR Checklist

  • Ensure PR contains only public links or terms
  • Use good commit messages
  • Squash the commits in this branch before merge to preserve our git history
  • If this PR is just an idea or POC, use a Draft PR instead of a full PR
  • Add appropriate labels according to what type of issue is being addressed.

@codecov-commenter
Copy link

Codecov Report

Merging #174 (5c85f4f) into main (1c17e4c) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #174      +/-   ##
==========================================
+ Coverage   36.27%   36.32%   +0.04%     
==========================================
  Files          20       20              
  Lines        2715     2717       +2     
==========================================
+ Hits          985      987       +2     
  Misses       1671     1671              
  Partials       59       59              
Files Coverage Δ
api/v1alpha1/akodeploymentconfig_types.go 100.00% <ø> (ø)
pkg/ako/values.go 61.93% <100.00%> (+0.26%) ⬆️

Copy link
Member

@XudongLiuHarold XudongLiuHarold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenlin07 chenlin07 merged commit 750ee0d into main Oct 27, 2023
4 checks passed
@chenlin07 chenlin07 deleted the topic/chenlin/change-boolean branch October 27, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants