Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1315] Fix for workload prematurely being declared unhealthy #1316

Merged
merged 2 commits into from
Aug 26, 2023

Conversation

tbr11
Copy link
Contributor

@tbr11 tbr11 commented Aug 16, 2023

Changes proposed by this PR

closes #1315

For immutable templates, their resource health is conditioned on the most recently stamped object. Prevents workloads stamping immutable templates to immediately be in Ready==False before later flipping to Ready==True.

When ResourcesSubmitted condition is MissingValueAtPath, the message is conditioned on the object's health condition:

  • healthy: cannot read value [some-path] from healthy object [some-resource/some-name] in namespace [some-namespace], contact Platform Eng
  • unhealthy: cannot read value [some-path] from unhealthy object [some-resource/some-name] in namespace [some-namespace], examine object, particularly whether it is receiving proper inputs
    unknown: waiting to read value [some-path] from object [some-resource/some-name] in namespace [some-namespace]

Release Note

bug fix for statuses on workloads being prematurely marked unhealthy

Cherry-pick branches

PR Checklist

Note: Please do not remove items. Mark items as done [x] or use strikethrough if you believe they are not relevant

  • Linked to a relevant issue. Eg: Fixes #123 or Updates #123
  • Removed non-atomic or wip commits
  • Filled in the Release Note section above
  • Added any relevant branches to cherry-pick
    - [ ] Modified the docs to match changes

@waciumawanjohi waciumawanjohi force-pushed the dont-prematurely-error-when-status-unknown branch from 74abb19 to 7603331 Compare August 25, 2023 20:29
@waciumawanjohi waciumawanjohi force-pushed the dont-prematurely-error-when-status-unknown branch from 7603331 to b9c6457 Compare August 25, 2023 21:24
@waciumawanjohi waciumawanjohi merged commit 3a40b24 into main Aug 26, 2023
3 checks passed
@waciumawanjohi waciumawanjohi deleted the dont-prematurely-error-when-status-unknown branch August 26, 2023 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

workloads with lifecycle:tekton templates go healthy==False
3 participants