Properly escalate the message from Runnable Conditions (#1154)

vmware-tanzu · Feb 16, 2023 · 4c5b600 · 4c5b600
1 parent 97cd626
commit 4c5b600
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 9 deletions.
diff --git a/pkg/conditions/runnable_conditions.go b/pkg/conditions/runnable_conditions.go
@@ -137,8 +137,9 @@ func StampedObjectConditionUnknown() metav1.Condition {
 
 func StampedObjectConditionKnown(condition *metav1.Condition) metav1.Condition {
 	return metav1.Condition{
-		Type:   v1alpha1.StampedObjectCondition,
-		Status: condition.Status,
-		Reason: v1alpha1.SucceededStampedObjectConditionReason,
+		Type:    v1alpha1.StampedObjectCondition,
+		Status:  condition.Status,
+		Reason:  v1alpha1.SucceededStampedObjectConditionReason,
+		Message: condition.Message,
 	}
 }
diff --git a/tests/integration/runnable/runnable_test.go b/tests/integration/runnable/runnable_test.go
@@ -895,9 +895,10 @@ var _ = Describe("Stamping a resource on Runnable Creation", func() {
 						),
 						MatchFields(IgnoreExtras,
 							Fields{
-								"Type":   Equal("StampedObjectCondition"),
-								"Status": Equal(metav1.ConditionFalse),
-								"Reason": Equal("SucceededCondition"),
+								"Type":    Equal("StampedObjectCondition"),
+								"Status":  Equal(metav1.ConditionFalse),
+								"Reason":  Equal("SucceededCondition"),
+								"Message": Equal("not a happy first stamped object"),
 							},
 						),
 						MatchFields(IgnoreExtras,
@@ -1005,9 +1006,10 @@ var _ = Describe("Stamping a resource on Runnable Creation", func() {
 						),
 						MatchFields(IgnoreExtras,
 							Fields{
-								"Type":   Equal("StampedObjectCondition"),
-								"Status": Equal(metav1.ConditionTrue),
-								"Reason": Equal("SucceededCondition"),
+								"Type":    Equal("StampedObjectCondition"),
+								"Status":  Equal(metav1.ConditionTrue),
+								"Reason":  Equal("SucceededCondition"),
+								"Message": Equal("happy second stamped object"),
 							},
 						),
 						MatchFields(IgnoreExtras,