Skip to content
This repository has been archived by the owner on Jan 20, 2022. It is now read-only.

Populate price for unit resource #175

Merged
merged 17 commits into from
Feb 20, 2019
Merged

Populate price for unit resource #175

merged 17 commits into from
Feb 20, 2019

Conversation

kreddyj
Copy link
Contributor

@kreddyj kreddyj commented Feb 19, 2019 •
edited
Loading

What this PR does / why we need it:

  • At present, Purser populates NodePrices and StoragePrices. For cost evaluation at pod level we need price for unit cpu, price for unit memory, price for unit storage
  • This also fixes wrong time period for rate card cron job

Note:

  • Assumption that split ratio is 1:1 for cpu:memory
  • Some instance prices are shown as 0, which isn't correct as price also depends on insalled software etc. In such cases price is set to default price.

Which issue(s) this PR fixes :
Fixes a task in #174

@kreddyj kreddyj added enhancement New feature or request DB Pricing related to pricing or costing labels Feb 19, 2019
hemani19
hemani19 approved these changes Feb 20, 2019
View reviewed changes
Copy link
Contributor

@hemani19 hemani19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kreddyj kreddyj merged commit f1f74ed into vmware-archive:master Feb 20, 2019
@kreddyj kreddyj deleted the priceForUnitResource branch February 22, 2019 06:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hemani19 hemani19 hemani19 approved these changes

Assignees
No one assigned
Labels
cla-not-required DB enhancement New feature or request Pricing related to pricing or costing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kreddyj @hemani19 @vmwclabot