Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][UT] make device count general #12461

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MengqingCao
Copy link
Contributor

@MengqingCao MengqingCao commented Jan 27, 2025

While establishing integration tests for the plugin backend, in order to reuse vLLM's native UTs to the greatest extent, it is necessary to generalize the cuda hard-coded and related functions in vLLM's existing UTs.

This PR is the first in the UT rectification series of PRs.
Mainly changes:

  1. Move the cuda_device_count_stateless method to platform so that out-of-tree devices can implement the corresponding method.
  2. Provide a method to overwrite the envs.CUDA_VISIBLE_DEVICES environment variable so that vLLM can still obtain the out-of-tree device count through it.

@MengqingCao MengqingCao marked this pull request as draft January 27, 2025 03:04
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant