Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Oneshot Refactor] Rename get_shared_processor_src to get_processor_from_model #1108

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

horheynm
Copy link
Collaborator

@horheynm horheynm commented Jan 28, 2025

SUMMARY:

  • Rename get_shared_processor_src to get_processor_from_model
  • Appropriate signature on initialize_processor_from_path, where teacher should be optinal

TEST PLAN:

  • Pass all existing tests
  • Search get_shared_processor_src using pygrep
  3 function pygrep() {
  2     local search_term="$1"
  1     shift
126     local search_dirs="${*:-src examples tests}"                           
  1     grep -rn --include="*.py" -E "$search_term" $search_dirs
  2 }

Copy link

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed.

@horheynm horheynm added the ready When a PR is ready for review label Jan 28, 2025
@horheynm horheynm changed the title Rename get_shared_processor_src to get_processor_from_model [Oneshot Refactor] Rename get_shared_processor_src to get_processor_from_model Jan 28, 2025
Copy link
Collaborator

@kylesayrs kylesayrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you for breaking this out

@horheynm
Copy link
Collaborator Author

lgtm, thank you for breaking this out

No problem, Its easier to review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready When a PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants