Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Entity implement IComparable #510

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

robertlarkins
Copy link
Contributor

Having Entity implement IComparable allows entities to be implicitly used as equality components in ValueObjects.

This PR relates to Issue #509.

Having Entity implement IComparable allows entities to be
implicitly used as equality components in ValueObjects.
@robertlarkins
Copy link
Contributor Author

Would be good to have the following checked:

  • Entity.CompareTo has the desired implementation
  • Entity generic type TId should implement IComparable<TId>
  • The tests are adequate and their names are appropriate

@vkhorikov
Copy link
Owner

Looks great, merging, will be published shortly with v2.40.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants