Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store precision as a resource on DOI claiming #3960

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

litvinovg
Copy link
Collaborator

VIVO GitHub issue

What does this pull request do?

Fixes imported date precision.

What's new?

Store imported date precision as a resource, not string literal.

How should this be tested?

  • Reproduce the problem in the issue
  • Test that the pull request resolves the issue

Interested parties

@VIVO-project/vivo-committers

@litvinovg litvinovg linked an issue Mar 19, 2024 that may be closed by this pull request
@litvinovg litvinovg requested a review from matthiasluehr March 19, 2024 17:04
@brianjlowe
Copy link
Member

Tested per procedure in issue: confirmed that literal is stored instead of URI in current code, rendering the publication date editing inoperable. With this PR, date is editable and precision is correctly stored as a URI reference.

@brianjlowe
Copy link
Member

Small bugfix PR, so can merge with single review.

@brianjlowe brianjlowe merged commit a5d0b41 into vivo-project:main Mar 20, 2024
4 checks passed
chenejac pushed a commit that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Claimed publication date precision saved as string literal
2 participants