-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved docker setup #3940
Improved docker setup #3940
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and works as intended! I left some comments that are open for discussion, if you have time, so please check them out 🙂
It might be helpful to some if there was a comment somewhere saying VIVO_HOST_PORT/SOLR_HOST_PORT can also specify host IP, but this should be obvious to anyone who knows how docker-compose files work so not an large concern. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks excellent now 🙂 great work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wwelling well done. Thanks for this. I don't have any complaint, meaning from my point of view this is ready to be merged.
@chenejac @ivanmrsulja Can we write down more information about what was tested and reviewed? |
Tested by Ian Slatter, tested and reviewed by Ivan Mrsullja (linux), reviewed by Dragan Ivanovic. |
VIVO GitHub issue: #3939
What does this pull request do?
This PR provides more configurability for docker compose and build of the VIVO docker image. Primarily addressing port mapping configuration via
.env
file fordocker-compose.yml
variable substitution.What's new?
.env
How should this be tested?
This can be tested by following https://github.com/wwelling/VIVO/blob/issue-3939/README.md#docker-compose. For more exhaustive testing the
.env
file can be modified between container restarts for desired effect.Interested parties
@chenejac, @isl3