fix: HTML title generated from heading should not have ruby text and …

…HTML tags - fix #166
vivliostyle · Oct 13, 2023 · e8df7e4 · e8df7e4
1 parent 76721d2
commit e8df7e4
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/src/plugins/metadata.ts b/src/plugins/metadata.ts
@@ -105,7 +105,10 @@ const readTitleFromHeading = (tree: Node): string | undefined => {
   heading.children = heading.children.filter(
     (child: Node) => child.type !== 'footnote',
   );
-  const text = toString(heading);
+  // Remove ruby text and HTML tags
+  const text = toString(heading)
+    .replace(/{(.+?)(?<=[^\\|])\|(.+?)}/g, '$1')
+    .replace(/<[^<>]*>/g, '');
   heading.children = children;
 
   return text;

diff --git a/src/plugins/slug.ts b/src/plugins/slug.ts
@@ -40,7 +40,7 @@ const createSlug = (heading: Heading, slugger: GithubSlugger) => {
   heading.children = heading.children.filter(
     (child: Node) => child.type !== 'footnote',
   );
-  const text = slugger.slug(toString(heading));
+  const text = slugger.slug(toString(heading).replace(/<[^<>]*>/g, ''));
   heading.children = children;
 
   return text;

diff --git a/tests/metadata.test.ts b/tests/metadata.test.ts
@@ -102,7 +102,7 @@ other-meta2: 'other2'
       ],
       [
         { name: 'rel', value: 'stylesheet' },
-        { name: 'type', value: 'text/css'},
+        { name: 'type', value: 'text/css' },
         { name: 'href', value: 'sample2.css' },
       ],
     ],
@@ -130,8 +130,10 @@ other-meta2: 'other2'
 });
 
 it('Title from heading', () => {
-  const received = readMetadata(`# Heading Title`);
-  const expected = 'Heading Title';
+  const received = readMetadata(
+    `# Heading Title with {Ruby|ルビ} and <mark>HTML tag</mark>`,
+  );
+  const expected = 'Heading Title with Ruby and HTML tag';
 
   expect(received.title).toBe(expected);
 });