Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add scriptor access flag #1032

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

phorward
Copy link
Member

@phorward phorward commented Jan 17, 2024

  • Adds access flag scriptor
  • Documentation for the default access flags and the default roles
  • User default access flag with scriptor for users having the admin-role

@phorward phorward added feature New feature or request documentation Improvements or additions to documentation viur-meeting Issues to discuss in the next ViUR meeting labels Jan 17, 2024
@phorward phorward removed the viur-meeting Issues to discuss in the next ViUR meeting label Jan 25, 2024
Copy link
Member

@sveneberth sveneberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the new roles are okay for me. But where do we use them? You didn't change a can* method of a module/prototype 🤔

akelch
akelch previously approved these changes Feb 1, 2024
ArneGudermann
ArneGudermann previously approved these changes Feb 1, 2024
@phorward
Copy link
Member Author

phorward commented Feb 1, 2024

Well, the new roles are okay for me. But where do we use them? You didn't change a can* method of a module/prototype 🤔

You're right. My initial intention behind this was to display the "scriptor"-button in the Admin. I will have further consideration about this and let you know.

@phorward phorward marked this pull request as draft February 1, 2024 10:10
@phorward phorward added this to the ViUR-core v3.6 milestone Feb 15, 2024
@phorward phorward changed the base branch from develop to main March 21, 2024 20:38
@phorward phorward dismissed stale reviews from ArneGudermann and akelch March 21, 2024 20:38

The base branch was changed.

@Grashalmbeisser
Copy link
Contributor

There needs to be an distinction between a Flag and an Access right. Since "Scriptor" is not an Acces right but a usage privillege we should differentiate that as a flag not as a right.

@phorward phorward removed this from the ViUR-core v3.7 milestone Sep 18, 2024
@phorward phorward added this to the ViUR-core v3.7 milestone Nov 11, 2024
@phorward phorward marked this pull request as ready for review November 12, 2024 00:06
@phorward phorward changed the title feat: Add scriptor access right feat: Add scriptor access flag Nov 12, 2024
@phorward
Copy link
Member Author

Upated this PR in convenience with @akelch. Clarified naming convention, so an access flag is something like "root", "admin" or now "scriptor", and an access-right is the stuff with the "add", "edit", "delete", "view" or any other action-related.

@phorward phorward merged commit 3c988d0 into viur-framework:main Nov 12, 2024
3 checks passed
@phorward phorward deleted the feat-scriptor-access-right branch November 12, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation feature New feature or request
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

5 participants