-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reference Table DML Join Fix #17414
Open
harshit-gangal
wants to merge
4
commits into
vitessio:main
Choose a base branch
from
planetscale:reference-dml-fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Reference Table DML Join Fix #17414
+343
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Dec 19, 2024
Signed-off-by: Harshit Gangal <[email protected]>
harshit-gangal
force-pushed
the
reference-dml-fix
branch
from
December 20, 2024 13:55
79ddc2f
to
bc4eb4b
Compare
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
harshit-gangal
added
Type: Bug
Component: Query Serving
Backport to: release-20.0
Needs to be backport to release-20.0
Backport to: release-21.0
Needs to be backport to release-21.0
and removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Dec 23, 2024
harshit-gangal
requested review from
systay,
frouioui,
GuptaManan100,
arthurschreiber and
deepthi
as code owners
December 23, 2024 09:04
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17414 +/- ##
==========================================
- Coverage 67.64% 67.63% -0.02%
==========================================
Files 1583 1583
Lines 254043 254058 +15
==========================================
- Hits 171854 171837 -17
- Misses 82189 82221 +32 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Backport to: release-20.0
Needs to be backport to release-20.0
Backport to: release-21.0
Needs to be backport to release-21.0
Component: Query Serving
Type: Bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue with join query with reference table and sharded query.
An update/delete on reference table does not get routed to the source table.
This change checks the update/delete target and does not choose the alternate route of the query.
Backport Reason: Issue started after supporting join queries in DML from v20. This is a correctness issue as reference table is updated instead of the source table.
Related Issue(s)
Checklist