Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-19.0] Fix to prevent stopping buffering prematurely (#17013) #17203

Merged
merged 1 commit into from
Nov 11, 2024

Fix to prevent stopping buffering prematurely (#17013)

0a1ad60
Select commit
Loading
Failed to load commit list.
Merged

[release-19.0] Fix to prevent stopping buffering prematurely (#17013) #17203

Fix to prevent stopping buffering prematurely (#17013)
0a1ad60
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 11, 2024 in 0s

65.14% (-0.01%) compared to 1eeb89b, passed because coverage increased by 0% when compared to adjusted base (65.14%)

View this Pull Request on Codecov

65.14% (-0.01%) compared to 1eeb89b, passed because coverage increased by 0% when compared to adjusted base (65.14%)

Details

Codecov Report

Attention: Patch coverage is 74.71264% with 22 lines in your changes missing coverage. Please review.

Project coverage is 65.14%. Comparing base (1eeb89b) to head (0a1ad60).

Files with missing lines Patch % Lines
go/vt/vtgate/buffer/shard_buffer.go 40.00% 9 Missing ⚠️
go/vt/discovery/keyspace_events.go 85.71% 7 Missing ⚠️
go/vt/discovery/fake_healthcheck.go 66.66% 4 Missing ⚠️
go/vt/vtgate/buffer/buffer.go 80.00% 2 Missing ⚠️
Additional details and impacted files 
@@               Coverage Diff                @@
##           release-19.0   #17203      +/-   ##
================================================
- Coverage         65.14%   65.14%   -0.01%     
================================================
  Files              1560     1560              
  Lines            238215   238294      +79     
================================================
+ Hits             155197   155238      +41     
- Misses            83018    83056      +38

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov