Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-19.0] Close zookeeper topo connection on disconnect (#17136) #17191

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

vitess-bot[bot]
Copy link
Contributor

@vitess-bot vitess-bot bot commented Nov 8, 2024

Description

This is a backport of #17136

@vitess-bot vitess-bot bot added the Backport This is a backport label Nov 8, 2024
@vitess-bot vitess-bot bot requested a review from deepthi as a code owner November 8, 2024 22:11
@vitess-bot vitess-bot bot requested a review from mattlord as a code owner November 8, 2024 22:11
Copy link
Contributor Author

vitess-bot bot commented Nov 8, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@github-actions github-actions bot added this to the v19.0.8 milestone Nov 8, 2024
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.14%. Comparing base (dc9c65e) to head (e96822d).
Report is 1 commits behind head on release-19.0.

Files with missing lines Patch % Lines
go/vt/topo/zk2topo/zk_conn.go 50.00% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-19.0   #17191      +/-   ##
================================================
- Coverage         65.14%   65.14%   -0.01%     
================================================
  Files              1560     1560              
  Lines            238219   238215       -4     
================================================
- Hits             155189   155182       -7     
- Misses            83030    83033       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattlord mattlord merged commit 12e6bf6 into release-19.0 Nov 9, 2024
205 of 206 checks passed
@mattlord mattlord deleted the backport-17136-to-release-19.0 branch November 9, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant