-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Atomic Transaction Startcommit
api to return the commit state
#17116
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Harshit Gangal <[email protected]>
…hen the failure is certain Signed-off-by: Harshit Gangal <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17116 +/- ##
==========================================
+ Coverage 67.14% 67.17% +0.03%
==========================================
Files 1571 1571
Lines 252093 252295 +202
==========================================
+ Hits 169269 169484 +215
+ Misses 82824 82811 -13 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
This PR adds StartCommit API state to the response from VTTablet.
This can be used by VTGate as Transaction Coordinator to take faster rollback decision.
There are 3 states:
Related Issue(s)
Checklist