Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix release 18 again #17069

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Fix release 18 again #17069

merged 2 commits into from
Oct 28, 2024

Conversation

systay
Copy link
Collaborator

@systay systay commented Oct 25, 2024 •
edited by deepthi
Loading

Description

This PR is on top of other planner bug fix PR that introduced a regression in a backport to v18.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Oct 25, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Oct 25, 2024
@systay systay changed the base branch from main to release-18.0 October 25, 2024 08:31
@github-actions github-actions bot added this to the v22.0.0 milestone Oct 25, 2024
@harshit-gangal harshit-gangal added Type: Bug Component: Query Serving Type: Regression and removed NeedsWebsiteDocsUpdate What it says NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Oct 28, 2024
@harshit-gangal harshit-gangal removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request labels Oct 28, 2024
@harshit-gangal harshit-gangal marked this pull request as ready for review October 28, 2024 08:49
harshit-gangal
harshit-gangal reviewed Oct 28, 2024
View reviewed changes
go/vt/vtgate/planbuilder/operators/SQL_builder.go Outdated
Comment on lines 569 to 572
qb.ctx.SkipPredicates[jc.RHSExpr] = nil

_ = qb.ctx.SkipJoinPredicates(jc.Original.Expr)
return jc.Original.Expr
})

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the error returned is not checked.
Should this be handled?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we talked about this with @systay, and handling the error leads to some changes in behaviour and various tests failures. 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was for Foreign keys but that should not happen anymore.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about any other test failing.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added the error checking. let's see what CI thinks 🤞

@harshit-gangal harshit-gangal merged commit ed60cc0 into vitessio:release-18.0 Oct 28, 2024
104 checks passed
@harshit-gangal harshit-gangal deleted the fix-release-18-again branch October 28, 2024 11:23
@arthurschreiber arthurschreiber mentioned this pull request Oct 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshit-gangal harshit-gangal harshit-gangal approved these changes

@arthurschreiber arthurschreiber arthurschreiber approved these changes

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 is a code owner

Assignees
No one assigned
Labels
Component: Query Serving Type: Bug Type: Regression
Projects
None yet
Milestone
v22.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@systay @arthurschreiber @harshit-gangal