Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unreachable errors when taking a backup #17062

Merged
merged 9 commits into from
Oct 29, 2024
Merged

Fix unreachable errors when taking a backup #17062

merged 9 commits into from
Oct 29, 2024

Commits on Oct 24, 2024

  1. Black box test to reproduce unreachable error in backups 

    Signed-off-by: Florent Poinsard <[email protected]>
    @frouioui
    frouioui committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    d04aec6 View commit details
    Browse the repository at this point in the history

  2. Add link to issue 

    Signed-off-by: Florent Poinsard <[email protected]>
    @frouioui
    frouioui committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    1f3e60e View commit details
    Browse the repository at this point in the history

  3. Use proper error variable 

    Signed-off-by: Florent Poinsard <[email protected]>
    @frouioui
    frouioui committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    73e48ee View commit details
    Browse the repository at this point in the history

  4. Remove unwanted log in unit test 

    Signed-off-by: Florent Poinsard <[email protected]>
    @frouioui
    frouioui committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    0e87ef5 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. Extract test to a non-race test 

    Signed-off-by: Florent Poinsard <[email protected]>
    @frouioui
    frouioui committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    bcdfcba View commit details
    Browse the repository at this point in the history

  2. Add release notes for known issue in v21.0.0 

    Signed-off-by: Florent Poinsard <[email protected]>
    @frouioui
    frouioui committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    75cd42d View commit details
    Browse the repository at this point in the history

  3. Update go/vt/mysqlctl/builtinbackupengine.go 

    Co-authored-by: Matt Lord <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
    @frouioui @mattlord
    frouioui and mattlord authored Oct 25, 2024
    Configuration menu
    Copy the full SHA
    cfbeeba View commit details
    Browse the repository at this point in the history

  4. Apply review suggestions 

    Signed-off-by: Florent Poinsard <[email protected]>
    @frouioui
    frouioui committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    a84400b View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. Merge remote-tracking branch 'origin/main' into fix-how-we-error-when… 

    …-backing-up

Signed-off-by: Florent Poinsard <[email protected]>
    @frouioui
    frouioui committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    1205315 View commit details
    Browse the repository at this point in the history