Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI for VTop example #16007

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

GuptaManan100
Copy link
Member

@GuptaManan100 GuptaManan100 commented May 24, 2024

Description

When we fixed the Vtop example in Vitess last time at #10687, we also tried to run it on CI, but unfortunately, the CI didn't have enough power to run them. Since then we've gotten access to 16 cor runners, and it is now possible to run the Vtop workflow.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Manan Gupta <[email protected]>
Copy link
Contributor

vitess-bot bot commented May 24, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels May 24, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone May 24, 2024
@GuptaManan100 GuptaManan100 added Type: Testing Component: Operator Vtop related issues and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels May 24, 2024
Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.16%. Comparing base (9c9a893) to head (e3ef5d7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16007      +/-   ##
==========================================
- Coverage   67.17%   67.16%   -0.02%     
==========================================
  Files        1571     1571              
  Lines      252249   252247       -2     
==========================================
- Hits       169459   169411      -48     
- Misses      82790    82836      +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuptaManan100
Copy link
Member Author

Even on the 16 core machines, the vttablets aren't reaching a ready state -

Warning  Unhealthy  72s (x713 over 21m)  kubelet            Readiness probe failed: dial tcp 10.244.0.20:3306: connect: connection refused

Even though the test works locally perfectly.

frouioui and others added 2 commits May 27, 2024 16:01
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
GuptaManan100 and others added 4 commits May 28, 2024 13:39
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
@frouioui frouioui removed this from the v20.0.0 milestone Jun 20, 2024
@frouioui frouioui added this to the v21.0.0 milestone Jun 20, 2024
Copy link
Contributor

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

  • Push additional commits to the associated branch.
  • Remove the stale label.
  • Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

@github-actions github-actions bot added the Stale Marks PRs as stale after a period of inactivity, which are then closed after a grace period. label Aug 18, 2024
Copy link
Contributor

This PR was closed because it has been stale for 7 days with no activity.

@github-actions github-actions bot closed this Aug 26, 2024
@frouioui frouioui reopened this Oct 30, 2024
@frouioui frouioui removed the Stale Marks PRs as stale after a period of inactivity, which are then closed after a grace period. label Oct 30, 2024
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
@GuptaManan100 GuptaManan100 marked this pull request as ready for review October 31, 2024 06:53
@frouioui frouioui modified the milestones: v21.0.0, v22.0.0 Oct 31, 2024
@@ -68,6 +68,10 @@ function checkPodStatusWithTimeout() {
sleep 1
done
echo -e "ERROR: checkPodStatusWithTimeout timeout to find pod matching:\ngot:\n$out\nfor regex: $regex"
vttabletPod=$(kubectl get pods | grep -E "vttablet" | head -n 1 | awk '{print $1}')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason not to use kubectl flags to get what we want rather than grep, head, and awk? That would be better IMO.

@@ -143,7 +143,6 @@ func run(cmd *cobra.Command, args []string) error {

qsc, err := createTabletServer(ctx, env, config, ts, tabletAlias, srvTopoCounts)
if err != nil {
ts.Close()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we just need to merge in origin/main rather than doing this here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants