-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI for VTop example #16007
base: main
Are you sure you want to change the base?
Add CI for VTop example #16007
Conversation
Signed-off-by: Manan Gupta <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16007 +/- ##
==========================================
- Coverage 67.17% 67.16% -0.02%
==========================================
Files 1571 1571
Lines 252249 252247 -2
==========================================
- Hits 169459 169411 -48
- Misses 82790 82836 +46 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Manan Gupta <[email protected]>
Even on the 16 core machines, the vttablets aren't reaching a ready state -
Even though the test works locally perfectly. |
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
dab5c44
to
c42e1e9
Compare
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:
If no action is taken within 7 days, this PR will be closed. |
This PR was closed because it has been stale for 7 days with no activity. |
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
122b7d6
to
a7fdc8e
Compare
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
@@ -68,6 +68,10 @@ function checkPodStatusWithTimeout() { | |||
sleep 1 | |||
done | |||
echo -e "ERROR: checkPodStatusWithTimeout timeout to find pod matching:\ngot:\n$out\nfor regex: $regex" | |||
vttabletPod=$(kubectl get pods | grep -E "vttablet" | head -n 1 | awk '{print $1}') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason not to use kubectl flags to get what we want rather than grep, head, and awk? That would be better IMO.
@@ -143,7 +143,6 @@ func run(cmd *cobra.Command, args []string) error { | |||
|
|||
qsc, err := createTabletServer(ctx, env, config, ts, tabletAlias, srvTopoCounts) | |||
if err != nil { | |||
ts.Close() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we just need to merge in origin/main rather than doing this here.
Description
When we fixed the Vtop example in Vitess last time at #10687, we also tried to run it on CI, but unfortunately, the CI didn't have enough power to run them. Since then we've gotten access to 16 cor runners, and it is now possible to run the Vtop workflow.
Related Issue(s)
Checklist
Deployment Notes