Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-19.0] Upgrade go version to go1.22.2 #15641

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

frouioui
Copy link
Member

@frouioui frouioui commented Apr 4, 2024

Description

This PR upgrade the go version used to go1.22.2

Copy link
Contributor

vitess-bot bot commented Apr 4, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Apr 4, 2024
@frouioui frouioui added Type: CI/Build Component: General Changes throughout the code base and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Apr 4, 2024
@github-actions github-actions bot added this to the v19.0.2 milestone Apr 4, 2024
Signed-off-by: Florent Poinsard <[email protected]>
@frouioui
Copy link
Member Author

frouioui commented Apr 4, 2024

bootstrap images are built and pushed, forced push to re-trigger CI

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.44%. Comparing base (29aa14d) to head (17b4921).
Report is 1 commits behind head on release-19.0.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-19.0   #15641      +/-   ##
================================================
+ Coverage         67.43%   67.44%   +0.01%     
================================================
  Files              1560     1560              
  Lines            192672   192672              
================================================
+ Hits             129920   129954      +34     
+ Misses            62752    62718      -34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shlomi-noach shlomi-noach merged commit 811d304 into release-19.0 Apr 4, 2024
199 checks passed
@shlomi-noach shlomi-noach deleted the bump-go-release-19.0 branch April 4, 2024 03:55
@frouioui frouioui restored the bump-go-release-19.0 branch November 11, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: General Changes throughout the code base Type: CI/Build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants