Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

datetime: obey the evalengine's environment time #14358

Merged
merged 1 commit into from
Oct 25, 2023
Merged

datetime: obey the evalengine's environment time #14358

merged 1 commit into from
Oct 25, 2023

Conversation

vmg
Copy link
Collaborator

@vmg vmg commented Oct 25, 2023 •
edited by dbussink
Loading

Description

The evaluation environment in the evalengine sets a frozen time.Time value upon creation, to ensure that all time-related APIs in the engine are evaluated consistently, following MySQL's behavior.

However, there are APIs in the datetime package that call time.Now() directly, particularly when converting from a time value to a datetime value. This is not correct! These APIs must use the frozen time set in the evalengine. This PR updates the APIs to take a time input when necessary.

cc @dbussink

Related Issue(s)

Found when working on #14310, follow up to #14351

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@vitess-bot
Copy link
Contributor

vitess-bot bot commented Oct 25, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Oct 25, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Oct 25, 2023
vmg
vmg commented Oct 25, 2023
View reviewed changes
go/vt/vtgate/evalengine/compiler_test.go
@@ -478,6 +480,7 @@ func TestCompilerSingle(t *testing.T) {
}

env := evalengine.EmptyExpressionEnv()
env.SetTime(time.Date(2023, 10, 24, 12, 0, 0, 0, tz))
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dbussink: the tests we wrote yesterday break if they're not run yesterday 😅

@dbussink dbussink added Type: Bug Component: Evalengine changes to the evaluation engine and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Oct 25, 2023
@vmg vmg merged commit cd2babb into main Oct 25, 2023
229 of 232 checks passed
@vmg vmg deleted the vmg/datetime-now branch October 25, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@systay systay systay approved these changes

@dbussink dbussink dbussink approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

Assignees
No one assigned
Labels
Component: Evalengine changes to the evaluation engine Type: Bug
Projects
None yet
Milestone
v19.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@vmg @dbussink @systay