Skip to content

Commit

Permalink
Cherry-pick 8952b5a with conflicts
Browse files Browse the repository at this point in the history
  • Loading branch information
vitess-bot[bot] authored and vitess-bot committed Nov 11, 2024
1 parent 482bab1 commit b082234
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions go/vt/vttablet/onlineddl/executor.go
Original file line number Diff line number Diff line change
Expand Up @@ -966,9 +966,22 @@ func (e *Executor) cutOverVReplMigration(ctx context.Context, s *VReplStream, sh

lockConn, err := e.pool.Get(ctx, nil)
if err != nil {
<<<<<<< HEAD

Check failure on line 969 in go/vt/vttablet/onlineddl/executor.go

View workflow job for this annotation

GitHub Actions / Code Coverage

syntax error: unexpected <<, expected }

Check failure on line 969 in go/vt/vttablet/onlineddl/executor.go

View workflow job for this annotation

GitHub Actions / Code Coverage

syntax error: unexpected <<, expected }
return err
}
defer lockConn.Recycle()

Check failure on line 972 in go/vt/vttablet/onlineddl/executor.go

View workflow job for this annotation

GitHub Actions / Code Coverage

syntax error: non-declaration statement outside function body

Check failure on line 972 in go/vt/vttablet/onlineddl/executor.go

View workflow job for this annotation

GitHub Actions / Code Coverage

syntax error: non-declaration statement outside function body
=======
return vterrors.Wrapf(err, "failed getting locking connection")
}
defer lockConn.Recycle()
// Set large enough `@@lock_wait_timeout` so that it does not interfere with the cut-over operation.
// The code will ensure everything that needs to be terminated by `migrationCutOverThreshold` will be terminated.
lockConnRestoreLockWaitTimeout, err := e.initConnectionLockWaitTimeout(ctx, lockConn.Conn, 5*migrationCutOverThreshold)
if err != nil {
return vterrors.Wrapf(err, "failed setting lock_wait_timeout on locking connection")
}
defer lockConnRestoreLockWaitTimeout()
>>>>>>> 8952b5af4e (Online DDL: fix defer function, potential connection pool exhaustion (#17207))

Check failure on line 984 in go/vt/vttablet/onlineddl/executor.go

View workflow job for this annotation

GitHub Actions / Code Coverage

invalid character U+0023 '#'

Check failure on line 984 in go/vt/vttablet/onlineddl/executor.go

View workflow job for this annotation

GitHub Actions / Code Coverage

invalid character U+0023 '#'
defer lockConn.Conn.Exec(ctx, sqlUnlockTables, 1, false)

renameCompleteChan := make(chan error)
Expand Down

0 comments on commit b082234

Please sign in to comment.