fix an unnecessary nested if

vitalik · Sep 21, 2024 · 78f06eb · 78f06eb
1 parent 74a918c
commit 78f06eb
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/ninja/orm/factory.py b/ninja/orm/factory.py
@@ -117,9 +117,8 @@ def convert_django_fields(
             raise ConfigError("Only one of 'fields' or 'exclude' should be set.")
 
         model_fields_list = list(self._selected_model_fields(model, fields, exclude))
-        if optional_fields:
-            if optional_fields == "__all__":
-                optional_fields = [f.name for f in model_fields_list]
+        if optional_fields and optional_fields == "__all__":
+            optional_fields = [f.name for f in model_fields_list]
 
         definitions = {}
         for fld in model_fields_list: