Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow setting the cursor #84

Merged
merged 2 commits into from
Nov 27, 2023
Merged

allow setting the cursor #84

merged 2 commits into from
Nov 27, 2023

Conversation

kushalkolar
Copy link
Contributor

Exposes style.cursor of the DOM element so that it can be changed. Tested with wgpu RFB canvas too.

cursor-2023-11-27_03.00.01.mp4

Copy link
Member

@almarklein almarklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but needs an update with main to get that lint error resolved.

Run flake8 .
./tests/test_widget.py:214:5: B017 assertRaises(Exception) and pytest.raises(Exception) should be considered evil. They can lead to your test passing even if the code being tested is never executed due to a typo. Assert for a more specific exception (builtin or custom),

It's interesting how flake8 tells us how to use pytest. On the other hand, it's a very good point.

@kushalkolar
Copy link
Contributor Author

good to go!

@almarklein almarklein merged commit 554b625 into vispy:main Nov 27, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants