change(vos-pass): add updates on challenger and account used for `SES…

…SION_KEY`
virto-network · Nov 29, 2024 · 0c9c765 · 0c9c765
1 parent 05cca24
commit 0c9c765
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 11 deletions.
diff --git a/vos-pass/src/index.ts b/vos-pass/src/index.ts
@@ -17,12 +17,10 @@ export class Pass {
   static async generateChallenge(
     api: ApiPromise
   ): Promise<[Uint8Array, Compact<BlockNumber>]> {
-    const block = await api.rpc.chain.getBlock();
-    const blockNumber = block.block.header.number;
-    const blockNumberBytes = blockNumber.toBn().toBuffer("le");
-
-    const hashed = await hash.blake2b(blockNumberBytes, 256);
-    return [hexToU8a(`0x${hashed}`), blockNumber];
+    const {
+      block: { header },
+    } = await api.rpc.chain.getBlock();
+    return [header.hash, header.number];
   }
 
   constructor(private api: ApiPromise) {}

diff --git a/vos-pass/tests/index.test.ts b/vos-pass/tests/index.test.ts
@@ -1,4 +1,3 @@
-// deno-lint-ignore-file no-explicit-any
 import { ApiPromise, Keyring } from "@polkadot/api";
 import { Blockchain, setStorage } from "npm:@acala-network/chopsticks";
 import type {
@@ -123,7 +122,6 @@ describe("Pass", opts, () => {
       // Define origin and user information
       const user = {
         id: hashedUserId,
-        name: "testuser",
         displayName: "Test User",
       };
 
@@ -135,7 +133,6 @@ describe("Pass", opts, () => {
           },
           user: {
             id: user.id,
-            name: user.name,
             displayName: user.displayName,
           },
           challenge,
@@ -172,6 +169,7 @@ describe("Pass", opts, () => {
       const ALICE = KEYRING.addFromUri("//Alice");
       const result = await signSendAndWait(tx, ALICE);
 
+      // Verification
       expect(result.events).toContainEqual({
         event: {
           method: "Registered",
@@ -225,9 +223,10 @@ describe("Pass", opts, () => {
         new Uint8Array(assertionResponse.response.signature)
       );
 
-      const SESSION_KEY = KEYRING.addFromUri("//Alice");
+      const SESSION_KEY = KEYRING.addFromUri("//Bob");
       const result = await signSendAndWait(tx, SESSION_KEY);
 
+      // Verification
       expect(result.events).toContainEqual({
         event: {
           section: "pass",
@@ -258,7 +257,7 @@ describe("Pass", opts, () => {
       });
 
       // We'll use the previously used session key.
-      const SESSION_KEY = KEYRING.addFromUri("//Alice");
+      const SESSION_KEY = KEYRING.addFromUri("//Bob");
       const SESSION_KEY_FREE_AMOUNT = await kreivoApi.query.system.account(
         SESSION_KEY.address
       );