Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for Django 1.8 / Python 2.7: #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes for Django 1.8 / Python 2.7: #12

wants to merge 1 commit into from

Conversation

trevoriancox
Copy link

  • CACHES default overwrites settings.py.
  • HttpResponseNotModified does not accept mimetime parameter.

Fixes for Django 1.8 / Python 2.7:
b4149e2 
- CACHES default overwrites settings.py.
- HttpResponseNotModified does not accept mimetime parameter.
vinyll
vinyll reviewed Aug 6, 2016
View reviewed changes
imagefit/views.py
@@ -41,7 +41,7 @@ def resize(request, path_name, format, url):
statobj = os.stat(image.path)
if not was_modified_since(request.META.get('HTTP_IF_MODIFIED_SINCE'),
statobj[stat.ST_MTIME], statobj[stat.ST_SIZE]):
return HttpResponseNotModified(mimetype=image.mimetype)
return HttpResponseNotModified() #mimetype=image.mimetype)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove the comment #mimetype=image.mimetype) here?
If we get rid of it let's just clear it out

egon0 added a commit to egon0/django-imagefit that referenced this pull request Nov 5, 2016
@egon0
HttpResponseNotModified does not accept mimetime parameter. @vinyll#12
3543708
@vinyll vinyll force-pushed the master branch 2 times, most recently from 0a17394 to 7b8b1b1 Compare September 7, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trevoriancox @vinyll