Skip to content

Commit

Permalink
Made the Outline main menu more consistent
Browse files Browse the repository at this point in the history
  • Loading branch information
vincode-io committed Sep 14, 2024
1 parent 4264fdb commit 8b66829
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 8 deletions.
2 changes: 1 addition & 1 deletion Zavala/AppAssets.swift
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ extension String {
static let documentNotFoundMessage = String(localized: "The requested document could not be found. It was most likely deleted and is no longer available.", comment: "Alert Message: Document Not Found")
static let doneControlLabel = String(localized: "Done", comment: "Control Label: Done")
static let duplicateControlLabel = String(localized: "Duplicate", comment: "Control Label: Duplicate")
static let duplicateRowControlLabel = String(localized: "Duplicate Row", comment: "Control Label: Duplicate Row")
static let duplicateRowsControlLabel = String(localized: "Duplicate Rows", comment: "Control Label: Duplicate Rows")

static let editorControlLabel = String(localized: "Editor", comment: "Control Label: Editor")
static let emailControlLabel = String(localized: "Email", comment: "Control Label: Email")
Expand Down
9 changes: 5 additions & 4 deletions Zavala/AppDelegate.swift
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ class AppDelegate: UIResponder, UIApplicationDelegate, FileActionResponder {
input: "{",
modifierFlags: [.command])

let deleteCurrentRowsCommand = UIKeyCommand(title: .deleteRowControlLabel,
let deleteCurrentRowsCommand = UIKeyCommand(title: .deleteRowsControlLabel,
action: .deleteCurrentRows,
input: UIKeyCommand.inputDelete,
modifierFlags: [.shift, .command])
Expand All @@ -125,7 +125,7 @@ class AppDelegate: UIResponder, UIApplicationDelegate, FileActionResponder {
input: "g",
modifierFlags: [.alternate, .command])

let duplicateRowsCommand = UIKeyCommand(title: .duplicateRowControlLabel,
let duplicateRowsCommand = UIKeyCommand(title: .duplicateRowsControlLabel,
action: .duplicateCurrentRows,
input: "r",
modifierFlags: [.command, .control])
Expand Down Expand Up @@ -559,8 +559,9 @@ class AppDelegate: UIResponder, UIApplicationDelegate, FileActionResponder {
createRowInsideCommand,
createRowOutsideCommand,
duplicateRowsCommand,
deleteCurrentRowsCommand,
groupCurrentRowsCommand])
groupCurrentRowsCommand,
deleteCurrentRowsCommand
])
let moveRowMenu = UIMenu(title: "", options: .displayInline, children: [moveRowsLeftCommand, moveRowsRightCommand, moveRowsUpCommand, moveRowsDownCommand])
let completeMenu = UIMenu(title: "", options: .displayInline, children: [toggleCompleteRowsCommand, deleteCompletedRowsCommand])
let noteMenu = UIMenu(title: "", options: .displayInline, children: [rowNotesCommand, deleteRowNotesCommand])
Expand Down
2 changes: 1 addition & 1 deletion Zavala/Editor/EditorViewController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -3360,7 +3360,7 @@ private extension EditorViewController {
func duplicateRows(_ rows: [Row]) {
guard let undoManager, let outline else { return }

let command = DuplicateRowCommand(actionName: .duplicateRowControlLabel,
let command = DuplicateRowCommand(actionName: .duplicateRowsControlLabel,
undoManager: undoManager,
delegate: self,
outline: outline,
Expand Down
4 changes: 2 additions & 2 deletions Zavala/Resources/Localizable.xcstrings
Original file line number Diff line number Diff line change
Expand Up @@ -337,8 +337,8 @@
"Duplicate" : {
"comment" : "Control Label: Duplicate"
},
"Duplicate Row" : {
"comment" : "Control Label: Duplicate Row"
"Duplicate Rows" : {
"comment" : "Control Label: Duplicate Rows"
},
"Edit document “%@”" : {
"comment" : "Prompt: edit document"
Expand Down

0 comments on commit 8b66829

Please sign in to comment.