Skip to content

Commit

Permalink
remove image url from slack notification, fix missing comments
Browse files Browse the repository at this point in the history
  • Loading branch information
vigo committed Jun 10, 2021
1 parent 520b677 commit dd32d4f
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 10 deletions.
1 change: 0 additions & 1 deletion .github/workflows/go.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,5 +43,4 @@ jobs:
username: 'github'
icon_url: 'https://github.githubassets.com/images/modules/logos_page/GitHub-Mark.png'
color: '#00FFAA'
image_url: 'https://storage.googleapis.com/slack-images-cyclops/ci/It_Compiles_Ship_It.png'
title: ${{ github.repository }} -> ${{ github.sha }}
18 changes: 9 additions & 9 deletions app/app.go
Original file line number Diff line number Diff line change
Expand Up @@ -82,27 +82,27 @@ func (f *BasicAuthFlag) String() string {
}

var (
// ArgURL ...
// ArgURL holds URL input from command-line
ArgURL string

// OptVersionInformation ...
// OptVersionInformation holds boolean for displaying version information
OptVersionInformation *bool

// OptTimeout ...
// OptTimeout holds default timeout for network transport operations
OptTimeout *int

// OptVerboseOutput ...
// OptVerboseOutput holds boolean for displaying detailed output
OptVerboseOutput *bool

// OptJSONOutput ...
// OptJSONOutput holds boolean for json response instead of text
OptJSONOutput *bool

// OptHeaders ...
// OptHeaders holds custom request header key:value
OptHeaders HeadersFlag
// OptFind ...
// OptFind holds lookup string in the body of the response
OptFind *string

// OptBasicAuth ...
// OptBasicAuth holds basic auth key:value credentials
OptBasicAuth BasicAuthFlag

usage = `
Expand Down Expand Up @@ -250,7 +250,7 @@ func (c *CLIApplication) GetResult() error {
Timeout: timeout,
}

ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
ctx, cancel := context.WithTimeout(context.Background(), timeout)
defer cancel()

req, err := http.NewRequestWithContext(ctx, "GET", ArgURL, nil)
Expand Down

0 comments on commit dd32d4f

Please sign in to comment.