Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure border width/color in OverviewWidget. Fixes #335 #393

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Conversation

blammit
Copy link
Contributor

@blammit blammit commented Jul 17, 2023

This fixes the background rendering issue in mock mode on Mac for BatteryWidget, as the default border values (which are used if the border is not explicitly customized) seem to cause gradient rendering issues in the BatteryWidget.

This partially reverts 9b56b44, which removed the default border values from OverviewWidget.

The solar/evcs widgets are set to enabled to be given the blue border (i.e. indicate they are clickable).

This fixes the background rendering issue in mock mode on Mac for
BatteryWidget, as the default border values (which are used if the
border is not explicitly customized) seem to cause gradient rendering
issues in the BatteryWidget.

This partially reverts 9b56b44,
which removed the default border values from OverviewWidget.

The solar/evcs widgets are set to enabled to be given the blue border
(i.e. indicate they are clickable).
Copy link
Contributor

@DanielMcInnes DanielMcInnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@blammit blammit merged commit 0e3abc4 into main Jul 19, 2023
1 check passed
@blammit blammit deleted the battery-bg branch July 19, 2023 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants