Revert "347 keep settings up to date with gui v1" #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a switch to enable an alarm that triggers when the auto start function is left disabled for more than 10 minutes. The 'VRM Portal ID' now shows valid data instead of 'TODO'.
Settings -> Generator start / stop -> Settings -> Run time and service
When editing a ListTextField, we would write the new value to the data point,
then emit 'root.accepted(text)'.
This causes problems for ListTextFields where the secondary text is different
to the raw value of the DataPoint, such as the generator service interval,
where the DataPoint stores the value in seconds, and the secondary text is
presented in hours, as follows (elided for brevity):
ListTextField {
id: serviceInterval
text: qsTrId("page_settings_generator_service_interval")
secondaryText: Math.round(dataValue / 60 / 60)
dataSource: settingsBindPrefix + "/ServiceInterval"
onAccepted: function(hours) {
setDataValue(hours * 60 * 60)
}
}
The user might change the service interval to 1000 hours. The data point gets
set to '1000'. The 'serviceInterval' object detects that the 'dataValue' has
changed, and updates the secondary text to 1000 / 60 / 60, i.e. 0.2, which gets
displayed as 0. ListTextField continues its 'onAccepted' routine, and emits
'root.accepted(text)', which is now equal to 0. The 'serviceInterval' object
runs 'onAccepted', and calls 'setDataValue(hours * 60 * 60)', which in this
case, is equal to 0.
This reverts commit 15974a8.
This reverts commit 8eb4585.
This reverts commit cc37011.
This reverts commit 62f1e03.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #387