-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Idle and start page fixes #1618
Conversation
This reverts commit e8c6e9b. fullScreenWhenIdle should be kept, because the "page idle" state is different from the "application idle" state. When the page is in the idle state, this means it can be expanded/resized in this state, and the navbar and status bar should be hidden. This is true for the Brief, Overview and Levels pages. However, the Notifications and Settings pages should not be expanded/resized in the page idle state. Part of #1617
It is the timeout option that affects whether the app reverts to the start page when inactive, not the start page option. Part of #1617
pages/MainView.qml
Outdated
// Auto-select the start page when the application is idle, if configured to do so. | ||
Connections { | ||
target: Global | ||
enabled: Global.systemSettings.startPageConfiguration.autoSelect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this need: Global.systemSettings && Global.systemsettings.startPageConfiguration.autoSelect
so that it doesn't break during disconnection / rebuildUi() cases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, yes fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit, but LGTM
There are two idle states to consider: - Page idle state: after 8 sconds of inactivity, the current page goes into idle mode, if it supports it. In this mode, it may expand to full screen, and the page is non-interactive, until the user taps the screen again. Pages go into idle state when the interaction mode is PageManager_InteractionMode_Idle. - Application idle state: after 60 seconds of inactivity, the current page is selected as the start page, if possible. These should be handled separately, so that the start page auto- selection is handled via the application idle state, and not the page idle state. Part of #1617
ee23850
to
2881096
Compare
No description provided.