Idle and start page fixes #1618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e8c6e9b. fullScreenWhenIdle should be kept, because the "page idle" state is different from the "application idle" state. When the page is in the idle state, this means it can be expanded/resized in this state, and the navbar and status bar should be hidden. This is true for the Brief, Overview and Levels pages. However, the Notifications and Settings pages should not be expanded/resized in the page idle state. Part of #1617
It is the timeout option that affects whether the app reverts to the start page when inactive, not the start page option. Part of #1617
chriadam
reviewed
Oct 25, 2024
pages/MainView.qml
Outdated
| // Auto-select the start page when the application is idle, if configured to do so. | ||
| Connections { | ||
| target: Global | ||
| enabled: Global.systemSettings.startPageConfiguration.autoSelect |
There was a problem hiding this comment.
does this need: Global.systemSettings && Global.systemsettings.startPageConfiguration.autoSelect so that it doesn't break during disconnection / rebuildUi() cases?
There are two idle states to consider: - Page idle state: after 8 sconds of inactivity, the current page goes into idle mode, if it supports it. In this mode, it may expand to full screen, and the page is non-interactive, until the user taps the screen again. Pages go into idle state when the interaction mode is PageManager_InteractionMode_Idle. - Application idle state: after 60 seconds of inactivity, the current page is selected as the start page, if possible. These should be handled separately, so that the start page auto- selection is handled via the application idle state, and not the page idle state. Part of #1617
blammit
force-pushed
the
blam/idle-and-start-page-fixes
branch
from
ee23850
to
2881096
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.