add info for user to troubleshoot MQTT #1614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhofstee
force-pushed
the
jeroen/mqtt-info
branch
from
b29fab6
to
5accfb4
Compare
blammit
reviewed
Oct 24, 2024
| id: connectionStatus | ||
|
|
||
| // Status of vrmlogger | ||
| property VeQuickItem httpsConnectionError: VeQuickItem { |
There was a problem hiding this comment.
Doesn't need to be a property, since the parent is an Item. Same for the VeQuickItems below.
There was a problem hiding this comment.
Oh never mind, I see that you want to access these as properties.
| uid: Global.venusPlatform.serviceUid + "/Mqtt/Bridges/GXrpc/ConnectionStatus" | ||
| } | ||
|
|
||
| property bool anyError: |
There was a problem hiding this comment.
I made this change, and force-pushed.
This adds the MQTT connection errors to VRM online portal menu as well. The MQTT connection errors are not shown if a bridge is disabled. If an error is present all error status are shown unless explicitly reported as disabled.
blammit
force-pushed
the
jeroen/mqtt-info
branch
from
5accfb4
to
a97abf3
Compare
|
Haven't tested this against a specific installation with all these configurations, but page loads fine. |
blammit
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the MQTT connection errors to VRM online portal menu as well. The MQTT connection errors are not shown if a bridge is disabled. If an error is present all error status are shown unless explicitly reported as disabled.