Fetch CAN bus stats from venus-platform #375

victronenergy · Jul 20, 2023 · f79449c · f79449c
1 parent a3de9d6
commit f79449c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 12 deletions.
diff --git a/data/SystemSettings.qml b/data/SystemSettings.qml
@@ -118,12 +118,6 @@ QtObject {
 		}
 	}
 
-	// TODO get canBusStats from venus-platform when available, as equivalent of vePlatform.canBusStats(gateway)
-	property var _canBusStats: ({})
-	function canBusStatistics(gateway) {
-		return _canBusStats[gateway] || ""
-	}
-
 	function reset() {
 		// no-op
 	}

diff --git a/pages/settings/PageCanbusStatus.qml b/pages/settings/PageCanbusStatus.qml
@@ -28,15 +28,11 @@ Page {
 			if (!root.gateway) {
 				return
 			}
-			const statsText = Global.systemSettings.canBusStatistics(root.gateway)
 			let stats
 			try {
-				stats = JSON.parse(statsText)[0]
+				stats = JSON.parse(canBusStats.value)[0]
 			} catch (e) {
-				console.warn("Unable to parse JSON:", statsText, "exception:", e)
-
-				// TODO requires venus-platform backend
-				console.warn("TODO Global.systemSettings.canBusStatistics() not yet implemented!!")
+				console.warn("Unable to parse JSON:", canBusStats.value, "exception:", e)
 				return
 			}
 			if (!stats) {
@@ -119,4 +115,9 @@ Page {
 			}
 		}
 	}
+
+	DataPoint {
+		id: canBusStats
+		source: "com.victronenergy.platform/CanBus/Interface/" + gateway + "/Statistics"
+	}
 }