Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress warnings in Elixir 1.17 and 1.18 + improvements #46

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

k-asm
Copy link

@k-asm k-asm commented Jun 14, 2024

This PR contains below changes.

  • Fix warnings in elixir 1.17 like:
    • using map.field notation (without parentheses) to invoke function ParamsTest.StringArray.__changeset__() is deprecated, you must add parentheses instead: remote.function()
    • use Mix.Config is deprecated
  • Fix some tests failed in OTP 26+ due to map key orders.
  • Use GitHub Actions instead of Travis CI.
  • Update dependencies:
New:
  telemetry 1.2.1
Upgraded:
  decimal 1.5.0 => 2.1.1 (major)
  dialyxir 0.5.0 => 0.5.1
  earmark_parser 1.4.18 => 1.4.39
  ecto 3.0.1 => 3.11.2
  ex_doc 0.26.0 => 0.34.0 (minor)
  makeup 1.0.5 => 1.1.2
  makeup_elixir 0.15.2 => 0.16.2 (minor)
  makeup_erlang 0.1.1 => 1.0.0 (major)
  nimble_parsec 1.2.0 => 1.4.0

  • Fix warnings in elixir 1.18 like:
    • Module.eval_quoted/2 is deprecated

Copy link

@mathieujobin mathieujobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should probably use "squash commits" on merge

@dmy-gh
Copy link

dmy-gh commented Sep 11, 2024

Any chance this can be merged @k-asm as it has been approved?

@k-asm
Copy link
Author

k-asm commented Sep 11, 2024

@vic
could you please review & merge this? (and hopefully see #47)

@guess
Copy link

guess commented Sep 30, 2024

Yes can we please get this merged 🙏

@mathieujobin
Copy link

@vic do you need help reviewing PRs ?

@k-asm
Copy link
Author

k-asm commented Dec 11, 2024

I have created the following PR to suppress compiler warnings in Elixir v1.18: mixi-m#4

Once our team's internal review is completed, it will be merged into the main branch of mixi-m/params and reflected in this pull request as well.

The original purpose of this PR was to suppress warnings in Elixir v1.17, but since there has been no activity in the repository, I plan to include suppression of warnings for v1.18 in this PR as well.

@k-asm k-asm changed the title Suppress warnings in Elixir 1.17 + improvements Suppress warnings in Elixir 1.17 and 1.18 + improvements Dec 11, 2024
@felipeUkio
Copy link

hi @k-asm, thanks for your work!

since this repo seems to be inactive is there a plan to continue maintain it in your fork?

Thanks!

@k-asm
Copy link
Author

k-asm commented Dec 16, 2024

Hi @felipeUkio

Yes, our team wants to continue to maintain this package, and I'm asking the maintener in #47.

We'll continue to maintain this repo in our fork until our request will approve. I will contact in this issue if the situation changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants