-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suppress warnings in Elixir 1.17 and 1.18 + improvements #46
base: master
Are you sure you want to change the base?
Conversation
warning: using map.field notation (without parentheses) to invoke function ParamsTest.StringArray.__changeset__() is deprecated, you must add parentheses instead: remote.function()
Suppress warnings in elixir 1.17
Update dependencies
Use Github Actions instead of Travis CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should probably use "squash commits" on merge
Any chance this can be merged @k-asm as it has been approved? |
Yes can we please get this merged 🙏 |
@vic do you need help reviewing PRs ? |
I have created the following PR to suppress compiler warnings in Elixir v1.18: mixi-m#4 Once our team's internal review is completed, it will be merged into the main branch of mixi-m/params and reflected in this pull request as well. The original purpose of this PR was to suppress warnings in Elixir v1.17, but since there has been no activity in the repository, I plan to include suppression of warnings for v1.18 in this PR as well. |
Suppress warnings in elixir 1.18
hi @k-asm, thanks for your work! since this repo seems to be inactive is there a plan to continue maintain it in your fork? Thanks! |
Hi @felipeUkio Yes, our team wants to continue to maintain this package, and I'm asking the maintener in #47. We'll continue to maintain this repo in our fork until our request will approve. I will contact in this issue if the situation changes. |
This PR contains below changes.
ParamsTest.StringArray.__changeset__()
is deprecated, you must add parentheses instead: remote.function()