Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSDK-5169 RSDK-4916 update dependencies and docs #4

Merged
merged 5 commits into from
Sep 26, 2023
Merged

RSDK-5169 RSDK-4916 update dependencies and docs #4

merged 5 commits into from
Sep 26, 2023

Conversation

abe-winter
Copy link
Contributor

@abe-winter abe-winter commented Sep 26, 2023 •
edited
Loading

What changed

  • dependencies: I changed rdk from 0.2.x to 0.9.x
  • bugfix: the CI was probably uploading the arm binary for both x86 + arm. this needs to be re-released after it's merged
  • docs: updated readme

Testing

I tested this in local exec mode on my laptop, it works

@abe-winter abe-winter marked this pull request as ready for review September 26, 2023 17:08
maximpertsov
maximpertsov approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@maximpertsov maximpertsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one option suggestion - otherwise LGTM

.github/workflows/deploy.yml Outdated Show resolved Hide resolved
@abe-winter @maximpertsov
--always-make in CI
fa3d667 
Co-authored-by: Maxim Pertsov <[email protected]>
@abe-winter abe-winter merged commit d17b09d into main Sep 26, 2023
1 check passed
@abe-winter abe-winter deleted the readme-cleanup branch September 26, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximpertsov maximpertsov maximpertsov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abe-winter @maximpertsov