Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert skipping creation of local adjoints for const params and declare those as non-const #1134

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

kchristin22
Copy link
Collaborator

No description provided.

@kchristin22 kchristin22 self-assigned this Nov 6, 2024
Copy link
Contributor

github-actions bot commented Nov 6, 2024

clang-tidy review says "All clean, LGTM! 👍"

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.46%. Comparing base (a50432f) to head (147ec67).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1134      +/-   ##
==========================================
- Coverage   94.46%   94.46%   -0.01%     
==========================================
  Files          50       50              
  Lines        8786     8784       -2     
==========================================
- Hits         8300     8298       -2     
  Misses        486      486              
Files with missing lines Coverage Δ
lib/Differentiator/ReverseModeVisitor.cpp 95.68% <100.00%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
lib/Differentiator/ReverseModeVisitor.cpp 95.68% <100.00%> (-0.01%) ⬇️

@vgvassilev vgvassilev merged commit 9070023 into vgvassilev:master Nov 6, 2024
90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants