Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ Use cached template when it is up-to-date #11

Merged
merged 12 commits into from
Jan 23, 2025

Conversation

ion098
Copy link
Contributor

@ion098 ion098 commented Dec 20, 2024

No description provided.

src/errors.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
src/commands/new.rs Outdated Show resolved Hide resolved
src/commands/new.rs Outdated Show resolved Hide resolved
@ion098 ion098 marked this pull request as ready for review December 24, 2024 20:29
src/commands/new.rs Outdated Show resolved Hide resolved
src/commands/new.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@zabackary zabackary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have write access to this repo so the feedback doesn't really matter (edit: apparently it's called "suggesting changes"), but here's some things I noticed while reviewing the code (the semver comment doesn't matter too much because this is a binary but I thought I'd include it anyway). It looks great overall though!

src/commands/new.rs Outdated Show resolved Hide resolved
src/errors.rs Show resolved Hide resolved
src/commands/new.rs Outdated Show resolved Hide resolved
src/commands/new.rs Outdated Show resolved Hide resolved
@ion098 ion098 changed the title ✨ Use cached template when it is up-to-date feat: ✨ Use cached template when it is up-to-date Jan 23, 2025
Copy link
Member

@Tropix126 Tropix126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tropix126 Tropix126 merged commit 7495cfc into vexide:main Jan 23, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants