Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: storm performance tracing #3821

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

WIP: storm performance tracing #3821

wants to merge 1 commit into from

Conversation

invisig0th
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 92.92929% with 7 lines in your changes missing coverage. Please review.

Project coverage is 97.62%. Comparing base (16ee721) to head (1dd8637).
Report is 1 commits behind head on master.

Files Patch % Lines
synapse/lib/ast.py 93.25% 6 Missing ⚠️
synapse/lib/node.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3821      +/-   ##
==========================================
- Coverage   97.73%   97.62%   -0.11%     
==========================================
  Files         239      239              
  Lines       51580    51671      +91     
==========================================
+ Hits        50412    50445      +33     
- Misses       1168     1226      +58     
Flag Coverage Δ
linux 97.62% <92.92%> (-0.02%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


async def wrapgenr(self, oper, genr):
# sudo make me a genr sandwich
pref = TracePreOper(self, oper, genr)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this generator sandwich is quite coming out correctly, I think both the pre/post trace operations are happening after the oper is actually run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants