Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Release Action #108

Merged
merged 6 commits into from
Mar 5, 2024
Merged

Add Release Action #108

merged 6 commits into from
Mar 5, 2024

Conversation

SunNathan
Copy link
Contributor

@SunNathan SunNathan commented Mar 5, 2024

This PR adds:

  • 2 github actions to automate the build of release artifacts.

(To activate the build, simply create a tag, and artifacts will be added automatically).

If you have any questions or suggestions for improvement, feel free to ask!

Here's a sample result:
Annotation 2024-03-05 092113

(close #71)

@versat versat requested a review from fralken March 5, 2024 10:16
@versat
Copy link
Owner

versat commented Mar 5, 2024

@fralken This looks great to me. You also played around with release workflows, what do you think?

@fralken
Copy link
Collaborator

fralken commented Mar 5, 2024

Yes last year I made a release workflow. It is a single file using the matrix strategy.
I didn't merge it here because my idea was also to add a release for macOS but then I never found time to investigate on it.
I'm not sure if it is better to have a single workflow file dedicated to all the releases or a workflow file for each platform.

Copy link

sonarqubecloud bot commented Mar 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@fralken
Copy link
Collaborator

fralken commented Mar 5, 2024

It looks good to me, too. It can be merged. Thanks a lot for this.

Anyway, I would wait creating a tag triggering the release until @gs-kamnas completes PR #97

@fralken fralken merged commit 85a14ad into versat:master Mar 5, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Are the build binaries avialable?
3 participants