Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix semvers of otel's peer dependencies #127

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix semvers of otel's peer dependencies #127

wants to merge 1 commit into from

Conversation

ammubhave
Copy link

&& is not a valid token in the semver requirement - see https://github.com/npm/node-semver/?tab=readme-ov-file#range-grammar. && is implicit and implied.

Although this works with most package manages because they run in loose mode and discard invalid tokens, installation fails when running on Deno because it enforces version range specifiers to strictly conform to the grammar.

When running deno install the following error is thrown:

error: Error in @vercel/[email protected] parsing version requirement for dependency "@opentelemetry/api-logs": ">=0.46.0 && <1.0.0"

Caused by:
    0: Invalid version requirement
    1: Unexpected character.
         >=0.46.0 && <1.0.0
         ~

See denoland/deno#26168 for related issue.

@vercel Vercel
Copy link

vercel bot commented Oct 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
otel-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2024 11:46pm

@ammubhave
Copy link
Author

Fixes #128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ammubhave