Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: avoid gpu memory increase #7405

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from

Conversation

robinfai
Copy link

@robinfai robinfai commented Aug 8, 2023

This modification can effectively control the memory usage growth of GPU processes as the number of tabs increases. In our internal terminal client, this modification achieved a 75% reduction in overall memory usage at the P95 percentile.

@LabhanshAgrawal
Copy link
Collaborator

Thanks for the pr. I think we should be able to use the fit addon when term gets active again instead of calling internal methods. Other than that, it looks good.

@github-actions
Copy link

Hi there,
Thank you for contributing to Hyper!
You can get the build artifacts from here.
Here are screenshots of Hyper built from this pr.
Imgur ImagesImgur ImagesImgur Images

@robinfai
Copy link
Author

Thanks for the pr. I think we should be able to use the fit addon when term gets active again instead of calling internal methods. Other than that, it looks good.

Because this size adjustment only involves the visible state of the terminal on the client-side, it is desired to keep the related operations within the client scope. Using the Fit addon for size synchronization involves exchanging size information between the client and the server, which may introduce some side effects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants