Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jwt claims #24

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Jwt claims #24

merged 2 commits into from
Oct 31, 2024

Conversation

setrofim
Copy link
Contributor

@setrofim setrofim commented Oct 30, 2024 •
edited
Loading

  • Fix setting of iat claims
  • Add an example that shows how to add and verify the exp JWT claim
  • Regenerated README using cargo-rdme

@setrofim
fix: properly set iat inside Ear::new()
6361d4f 
Set iat (issued at) claim to the current time when creating a new token.

Also, fix a minor typo in comment.

Signed-off-by: Sergei Trofimov <[email protected]>
@setrofim
doc: add exp claim example + use cargo-rdme
70d54bc 
- Add an example of using "exp" JWT claim inside an EAR to the crate
  documentation.
- Replace the hand-written README with one generated from the crate docs
  using cargo-rdme.

Signed-off-by: Sergei Trofimov <[email protected]>
@setrofim setrofim mentioned this pull request Oct 30, 2024
Closed
@setrofim
Copy link
Contributor Author

This addresses #20

@thomas-fossati
Copy link
Contributor

cc @fitzthum

thomas-fossati
thomas-fossati approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@thomas-fossati thomas-fossati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fitzthum
Copy link

fitzthum commented Oct 30, 2024 •
edited
Loading

Thanks @setrofim. This looks like it will work. Might be worth thinking about adding exp to the spec itself. I think it serves a different purpose than the nonce.

Also, note that currently I can't use extensions feature due to #19 which seems to have been introduced by the PR adding extensions.

@thomas-fossati
Copy link
Contributor

[...] Might be worth thinking about adding exp to the spec itself. I think it serves a different purpose than the nonce.

Good point. Could you please add an issue to the spec?

@setrofim setrofim merged commit d0e4d2d into main Oct 31, 2024
4 checks passed
@setrofim setrofim deleted the jwt-claims branch October 31, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomas-fossati thomas-fossati thomas-fossati approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@setrofim @thomas-fossati @fitzthum