-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cut #6.500, #6.502 in FromCOSE #133
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Top level tags are not interpretable as a COSE object. The protected header content-type is not meant to be application/rim+cbor according to the spec draft (Issue veraison#132). Support the spec's optional unsigned corim tag in COSE payload. Signed-off-by: Dionna Glaze <[email protected]>
I don't have permissions to merge. Did we decide I'd become a maintainer in the Veraison call? Or did I just suggest it? @yogeshbdeshpande |
I made you an admin to both |
@deeglaze : to your question: Did we decide I'd become a maintainer in the Veraison call? Yes certainly, as I said in the call, your contributions to Veraison project are highly Welcome & Appreciated! |
@deeglaze: Thank you for your changes, look good to me.! This change also demands a suggested change in the and also the associated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I suggest before merging this that we wait for the associated CoRIM PR to be merged. |
This is not strictly connected. The
If Dionna wants to do it, great, but she should not feel obligated to do it :-) |
|
Top level tags are not interpretable as a COSE object. The protected header content-type is not meant to be application/rim+cbor according to the spec draft (Issue #132).
Support the spec's optional unsigned corim tag in COSE payload.