fix(comid): bring ValueTriple into alignment with rev05 #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-fossati
changed the title
At rev00, for reference/endorsed value triples, the CoRIM spec associated an environment with one or more measurements, allowing for two layers of multiplicity. Since rev01, and up to (current) rev05, the spec removed the second layer, now associating an environment with exactly one measurement. This commit brings our implementation into alignment with the spec, replacing ValueTriple.Measurements collection with the single ValueTriple.Measurement. Signed-off-by: Sergei Trofimov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At rev00, for reference/endorsed value triples, the CoRIM spec associated an environment with one or more measurements, allowing for two layers of multiplicity.
Since rev01, and up to (current) rev05, the spec removed the second layer, now associating an environment with exactly one measurement.
This commit brings our implementation into alignment with the spec, replacing ValueTriple.Measurements collection with the single ValueTriple.Measurement.
This addresses #123