[stable-v2.0] fix build on gcc 13.x and some typo #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
restored other arch container to bullseye as workaround for build error:
/home/runner/work/blksnap/blksnap/lib/blksnap/TrackerCtl.cpp: In
member function 'void blksnap::CTrackerCtl::ReadCbtMap(unsigned int,
unsigned int, uint8_t*)':
/home/runner/work/blksnap/blksnap/lib/blksnap/TrackerCtl.cpp:93:5:
sorry, unimplemented: non-trivial designated initializers not supported
};
^
probably related to this:
https://stackoverflow.com/questions/31215971/non-trivial-designated-initializers-not-supported
but I not checked more for now
Fantu
changed the title
spotted with codespell
Fantu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
today while I was preparing a blksnap usage test on debian unstable the compilation was failed due to the error already reported in #65 so I did a quick search and made this fix which should solve the build issue with gcc 13 or higher
the PR include also commits of #66 because I keep for fast check it with circleci build on ubuntu 23.10
also fixed a typo on a test script extension and some typo spotted with codespell