Skip to content

Commit

Permalink
Merge pull request riscv-non-isa#264 from ved-rivos/1027
Browse files Browse the repository at this point in the history
do not qualify exec_req with pid_valid for untranslated requests
  • Loading branch information
ved-rivos authored Oct 27, 2023
2 parents 497a318 + 98fcbfc commit 9f693dd
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion iommu_ref_model/libiommu/src/iommu_translate.c
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ iommu_translate_iova(
req->device_id, 0 /* GSCV */, 0 /* GSCID */, TRANSLATION_REQUEST);
TTYP = TTYPE_NONE;
if ( req->tr.at == ADDR_TYPE_UNTRANSLATED && req->tr.read_writeAMO == READ ) {
if ( req->pid_valid && req->exec_req )
if ( req->exec_req )
TTYP = UNTRANSLATED_READ_FOR_EXECUTE_TRANSACTION;
else
TTYP = UNTRANSLATED_READ_TRANSACTION;
Expand Down
2 changes: 1 addition & 1 deletion iommu_ref_model/test/test_utils.c
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ check_rsp_and_faults(

EXP_TTYP = TTYPE_NONE;
if ( req->tr.at == ADDR_TYPE_UNTRANSLATED && req->tr.read_writeAMO == READ ) {
if ( req->pid_valid && req->exec_req )
if ( req->exec_req )
EXP_TTYP = UNTRANSLATED_READ_FOR_EXECUTE_TRANSACTION;
else
EXP_TTYP = UNTRANSLATED_READ_TRANSACTION;
Expand Down

0 comments on commit 9f693dd

Please sign in to comment.