Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade EVM to shanghai #941

Merged
merged 18 commits into from
Jan 15, 2025
Merged

Upgrade EVM to shanghai #941

merged 18 commits into from
Jan 15, 2025

Conversation

paologalligit
Copy link
Member

Description

This PR upgrades the internal evm to Shanghai version:

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • New and existing E2E tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have not added any vulnerable dependencies to my code

@paologalligit paologalligit requested a review from a team as a code owner January 14, 2025 10:46
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 57.51073% with 99 lines in your changes missing coverage. Please review.

Project coverage is 60.97%. Comparing base (c324231) to head (e8d1a85).

Files with missing lines Patch % Lines
vm/gas_table.go 8.69% 42 Missing ⚠️
vm/evm.go 61.66% 16 Missing and 7 partials ⚠️
vm/contracts.go 74.28% 17 Missing and 1 partial ⚠️
vm/instructions.go 27.27% 8 Missing ⚠️
vm/interpreter.go 0.00% 5 Missing ⚠️
runtime/runtime.go 66.66% 1 Missing and 1 partial ⚠️
vm/gas.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           galactica     #941      +/-   ##
=============================================
+ Coverage      60.95%   60.97%   +0.02%     
=============================================
  Files            220      220              
  Lines          23425    23518      +93     
=============================================
+ Hits           14278    14340      +62     
- Misses          7982     8011      +29     
- Partials        1165     1167       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@libotony libotony changed the title Shanghai Upgrade Upgrade EVM to shanghai Jan 15, 2025
@freemanzMrojo freemanzMrojo merged commit effd7f5 into release/galactica Jan 15, 2025
16 checks passed
@freemanzMrojo freemanzMrojo deleted the tony/eth_shanghai branch January 15, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants