Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics (Block processing lock): Number of times + duration #934

Open
wants to merge 5 commits into
base: release/maindbv4
Choose a base branch
from

Conversation

freemanzMrojo
Copy link
Member

Description

Metrics taken based on the description for Block processing lock here https://github.com/vechain/protocol-board-repo/issues/340 and taking metricBlockProcessedCount and metricBlockProcessedDuration as a reference.

@freemanzMrojo freemanzMrojo requested a review from a team as a code owner January 10, 2025 12:52
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 61.53%. Comparing base (571f607) to head (9b3076c).

Files with missing lines Patch % Lines
cmd/thor/node/node.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           feat/db     #934      +/-   ##
===========================================
- Coverage    61.54%   61.53%   -0.01%     
===========================================
  Files          217      217              
  Lines        22635    22641       +6     
===========================================
+ Hits         13930    13933       +3     
- Misses        7583     7587       +4     
+ Partials      1122     1121       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@libotony
Copy link
Member

As block processing duration is already captured, I would suggest this metric to be redundant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants